feat(3ds): WIP adding 3DS compatibility #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adi3000
force-pushed
the
feat/3ds-compatibility
branch
2 times, most recently
from
e1d4694 to
253cf13
Compare
Adi3000
force-pushed
the
feat/3ds-compatibility
branch
from
253cf13 to
4885558
Compare
cgutman
reviewed
Oct 29, 2023
| @@ -724,7 +724,7 @@ static bool parseUrlAddrFromRtspUrlString(const char* rtspUrlString, char* desti | |||
|
|
|||
| // SDP attributes are in the form: | |||
| // a=x-nv-bwe.bwuSafeZoneLowLimit:70\r\n | |||
| bool parseSdpAttributeToUInt(const char* payload, const char* name, unsigned int* val) { | |||
| bool parseSdpAttributeToUInt(const char* payload, const char* name, uint32_t* val) { | |||
There was a problem hiding this comment.
Is unsigned int 16 bits on 3DS or something?
There was a problem hiding this comment.
I'm debugging it but it seems that yes with only 3DS devkitpro installed. Don't know how it passed with WiiU, it may be this different...
cgutman
reviewed
Oct 29, 2023
CMakeLists.txt
Outdated
| target_compile_definitions(moonlight-common-c PRIVATE HAS_SOCKLEN_T) |
There was a problem hiding this comment.
This stuff will obviously need to be reverted before merge
There was a problem hiding this comment.
Sorry, yes : a little mess with my submodules and pushed branch
Adi3000
force-pushed
the
feat/3ds-compatibility
branch
from
4885558 to
67136dc
Compare
Adi3000
force-pushed
the
feat/3ds-compatibility
branch
from
67136dc to
d0375ae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.